Linux

48413 readers

1196 users here now

From Wikipedia, the free encyclopedia

Linux is a family of open source Unix-like operating systems based on the Linux kernel, an operating system kernel first released on September 17, 1991 by Linus Torvalds. Linux is typically packaged in a Linux distribution (or distro for short).

Distributions include the Linux kernel and supporting system software and libraries, many of which are provided by the GNU Project. Many Linux distributions use the word "Linux" in their name, but the Free Software Foundation uses the name GNU/Linux to emphasize the importance of GNU software, causing some controversy.

Rules

Posts must be relevant to operating systems running the Linux kernel. GNU/Linux or otherwise.
No misinformation
No NSFW content
No hate speech, bigotry, etc

Related Communities

Community icon by Alpár-Etele Méder, licensed under CC BY 3.0

founded 5 years ago

MODERATORS

[email protected]

208

RustDesk: I Found This Open-Source TeamViewer Alternative Impressive! (news.itsfoss.com)

submitted 2 months ago* (last edited 2 months ago) by [email protected] to c/[email protected]

100 comments fedilink hide all child comments

Please have a look at the warnings in the comments:

https://discuss.tchncs.de/post/21632052/12893621

https://discuss.tchncs.de/post/21632052/12897257

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 3 points 2 months ago* (last edited 2 months ago) (1 children)

Wth is that, that is the most anti-idiomatic code I have ever seen

https://github.com/rustdesk/rustdesk/blob/master/src%2Fplatform%2Flinux.rs#L176

pub fn get_cursor() -> ResultType<Option<u64>> {
    let mut res = None;
    DISPLAY.with(|conn| {
        if let Ok(d) = conn.try_borrow_mut() {
            if !d.is_null() {
                unsafe {
                    let img = XFixesGetCursorImage(*d);
                    if !img.is_null() {
                        res = Some((*img).cursor_serial as u64);
                        XFree(img as _);
                    }
                }
            }
        }
    });
    Ok(res)
}

I'm not an expert but this seems wrong.

[–] [email protected] 2 points 2 months ago

Yep, I'm not a Rust expert either, but this is pretty cursed. The comments on this post have some more examples of bad rustdesk code: https://lobste.rs/s/njfvjb/rustdesk_with_tailscale_on_arch_linux