this post was submitted on 07 Jun 2024
174 points (98.9% liked)

Fediverse

27506 readers
1152 users here now

A community to talk about the Fediverse and all it's related services using ActivityPub (Mastodon, Lemmy, KBin, etc).

If you wanted to get help with moderating your own community then head over to [email protected]!

Rules

Learn more at these websites: Join The Fediverse Wiki, Fediverse.info, Wikipedia Page, The Federation Info (Stats), FediDB (Stats), Sub Rehab (Reddit Migration), Search Lemmy

founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 5 points 2 months ago* (last edited 2 months ago) (2 children)

What a dumb way to do image proxying.

This is about proxying external images, URL rewrite won't work unless the image is also downloaded and hosted by the instance (which seems even worse for many reasons).
Or am I missing something here?

[–] [email protected] 9 points 2 months ago

Lemmy will rewrite the image URLs when saving a post.

But instead the URL should be rewritten when loading the post. That way the original URL wouldn't get lost and it would also work for old posts.

[–] [email protected] 3 points 2 months ago* (last edited 2 months ago) (1 children)

You're missing a lot.

I've done exactly what I described in my comment for the last 8 months: it's been a UI feature of Tesseract since last October.

It proxies any image or direct video from any source you haven't blacklisted. If you have the proxy option enabled in your settings, all image URLs are re-written to go through the proxy. If not, then it uses the regular URL directly. It also caches with an admin-defined policy.

[–] [email protected] 6 points 2 months ago (1 children)

Oh interesting I will have to look how tessaract does it

[–] [email protected] 5 points 2 months ago* (last edited 2 months ago)

And anywhere it renders an image (markdown, posts, avatars/icons, banners, etc), the image source is set via imageProxyURL(url). There's extra optional params for size and format if the image source is served by pict-rs.