Programming

17666 readers

361 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Follow the programming.dev instance rules
Keep content related to programming in some way
If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities [email protected]

founded 2 years ago

MODERATORS

[email protected]

196

Git grumpy: Torvalds complains of passive voice in merge commit messages (www.neowin.net)

submitted 2 months ago by [email protected] to c/[email protected]

53 comments fedilink hide all child comments

Linus Torvalds expressed frustration over the use of passive voice in merge commit messages, preferring active and imperative language instead.

He provided an example of how commit messages should be rewritten for clarity and consistency across the project.

Torvalds noted that while it's not a major issue, it does add extra work when he has to rewrite messages to match his preference.

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 1 points 2 months ago (2 children)

That's not scary. The trick when dealing with that kind of review is to parse out the technical and not take the rest personally, which maybe takes a certain kind of personality.

[–] [email protected] 4 points 2 months ago (1 children)

Not being a jerk and having empathy are two necessary things to create a healthy work environment and are especially required when volunteers take from their off-time to work on your project.

[–] [email protected] 0 points 2 months ago

I agree, but it's really not scary

[–] [email protected] 3 points 2 months ago

I do that by default. I have to actively think about empathy when I do CRs, because the other devs (who should not be doing these kinds of mistakes) just can't fucking do their job right for once.

But when I am getting a review, I don't get mad unless I am personally attacked (happened with a colleague who had a very high ego and somehow made it to a higher position, finally being let go about half a year back).