this post was submitted on 04 Nov 2023
1451 points (99.0% liked)

Comics

5687 readers
93 users here now

This is a community for everything comics related! A place for all comics fans.

Rules:

1- Do not violate lemmy.ml site-wide rules

2- Be civil.

3- If you are going to post NSFW content that doesn't violate the lemmy.ml site-wide rules, please mark it as NSFW and add a content warning (CW). This includes content that shows the killing of people and or animals, gore, content that talks about suicide or shows suicide, content that talks about sexual assault, etc. Please use your best judgement. We want to keep this space safe for all our comic lovers.

4- No Zionism or Hasbara apologia of any kind. We stand with Palestine 🇵🇸 . Zionists will be banned on sight.

5- The moderation team reserves the right to remove any post or comments that it deems a necessary for the well-being and safety of the members of this community, and same goes with temporarily or permanently banning any user.

Guidelines:

founded 4 years ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 1 points 9 months ago (1 children)

Very interesting: I didn't know all this about GitHub ! Could you please share some refs about the pull request model not scaling up ?

[–] [email protected] 3 points 9 months ago

I don’t have any off-hand. But anecdotally I know systems like Gerrit & mailing lists are used for very large and/or very rapid work flows. Nixpkgs has a lot of issues with thousands of open requests, not many reviewers, no way to understand the prioritization, required reviews even if you are the sole maintainer of a small package (so no other user to check the work), separate folks that do merging that are inundated with approved-but-unmerged changes who also… don’t know what to prioritize. This process alone can take weeks (I just now got a merge from 2023-09-29 just merged in) & that was only after having begged twice on the Matrix chat for someone to dedicate the time to do it. Traditionally bigger and/or distributed systems are used to help alleviate or add hierarchy to try to get pushes thru faster.

Another issue pops up with just the review process. You may have seen your favorite $PROG_X just released a new version. You have bumped the version + hash, & submitted a new request. The maintainer tells you all these little nits or stuff about how this package now breaks $PROG_Y & tells you to fix it… like it’s your problem when they are the maintainer. If I were to receive this as an email patch, I would just modify the patchset for you, reply with “Thanks. I made some small adjustments to fit match my style.” or whatever keeping the credit on them. You can amend a users repository iff they allow maintainer access, but adding new remotes is more cumbersome & it’s almost never done as we’ve decided now that the onus should be on contributors rather than helping them ship their changes faster.