I really liked the wavebird for the gamecube, unfortunately mine went into the aether on my last move, got bluetooth adapters to pair modern controllers with it but the wavebird was really cool at the time, was really amazing to not have to be tethered to the console and it being first party, though at the time the madcatz stuff was decent.

For recent controllers, I've been using a knockoff 360 controller for moonlight recently and after a lot of back and forth I really think MS nailed the controller setup back then (OG Xbox being decent but not a preference, I hated the duke, s controller was solid though), I like the xbone controllers as well, but IMO they're just iterations on the 360 controller, easily my preference as an all rounder controller layout.

I have a steam controller, used it for a while but it's been some time now, had some really great ideas, I'd totally go for an updated steamdeck style layout on that, probably a second for me.

I've had so much drift issues with ds4s that I personally don't reach for a ds4 or dualsense for non playstation games, I like being able to swap batteries and the Xbox/Steam controllers all seem to have way better battery life in general, I keep a stock of rechargeables around so not generating piles of waste.