this post was submitted on 12 Jul 2024
368 points (97.4% liked)

Programmer Humor

18961 readers
986 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
 

One does not commit or compile credentials

Template

Context:

This meme was brought to you by the PyPI Director of Infrastructure who accidentally hardcoded credentials - which could have resulted in compromissing the entire core Python ecosystem.

you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 9 points 1 month ago (2 children)

This sounds like a really useful solution, how do you implement something like this? Especially with linter integration

[–] [email protected] 7 points 1 month ago* (last edited 1 month ago)

I'm not sure, sorry. The source control team at work set it up a long time ago. I don't know how it works - I'm just a user of it.

The linter probably just runs git diff | grep @nocommit or similar.

[–] [email protected] 4 points 1 month ago (1 children)

Depending on which stack you’re using, you could use https://danger.systems to automatically fail PRs.

[–] [email protected] 4 points 1 month ago (1 children)

PRs? Isn't the point of @nocommit that something does not get committed, and therefore no credentials are stored in the git repository? Even if the PR does not get merged, the file is still stored as a hit object and can be restored.

[–] [email protected] 2 points 1 month ago

I read the lint part and my brain forgot about everything else. You could stick the danger call in a pre commit hook though.