this post was submitted on 22 Dec 2023
31 points (91.9% liked)

Programming

17576 readers
125 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities [email protected]



founded 2 years ago
MODERATORS
top 50 comments
sorted by: hot top controversial new old
[–] [email protected] 64 points 11 months ago (1 children)

When you can't reasonably use a loop or when it's not particularly important for performance and the recursive function is more readable.

Honestly, in code the absolute most important quality is readability. Readability should always be prioritized until you find performance issues that matter in a specific block of code.

[–] [email protected] 19 points 11 months ago (3 children)

On a side note: not caring about performance "until you find performance issues" is a huge problem with modern software imho. That's the reason apps are so slow, updates take so long, everything uses so much space. I'd wish that performance would always be a point of consideration, not an afterthought once there are problems.

[–] [email protected] 19 points 11 months ago (1 children)

I'd rather people err on the side of readability... senior devs should know the importance of readability but still lay decent groundwork towards performance... do things the right way when it can be simple.

Junior developers should just focus on readable code. Chances are their code will be slow, indecipherable, and wrong - I'd rather they focused on fixing the indecipherablity, the wrongness, and then the speed.

But, to sort of generally undermine my own point - no rule should be an absolute in software development - sometimes premature optimization is totally justified - you just need to use common sense.

[–] [email protected] 5 points 11 months ago (1 children)

I agree that junior devs should focus on readability, rather than focusing on everything and just getting it all wrong. but as you say, if you have more experience, performance should be a point of consideration.

[–] [email protected] 2 points 11 months ago

I think people talking about premature optimisation are often talking about micro-optimisations. Those are almost always unnecessary until you've identified choke points. Optimising the overall architecture of the code base on the other hand, is in my opinion something that should be thought about before you even start coding. That's where the major gains can often be done anyway.

[–] [email protected] 11 points 11 months ago* (last edited 11 months ago) (2 children)

I don’t think loop vs recursion choice is what significantly impacts performance in most cases. Most of the software I saw, suffer performance because of wrong API design or overall architecture. If app needs to fetch 100 objects from API which can provide only one object at the time no optimization will save that app.

App team - we need bulk API.

API team - cannot because of capacity, budget, backward compatibility, DB, 3rd patry API, not a KPI

Also it’s mostly QAs measuring performance and validating it with product guidelines which set by person who mostly detached from specific product and sometimes reality.

[–] [email protected] 3 points 11 months ago

I think loops tend to be faster, but well done recursion might be just as fast. I just wanted to mention performance being a point of consideration when making these decisions. I 100% agree that poor (API) architecture is probably one of the biggest reasons for slow software. It's just that every bit of poor performance adds up along the way, and then we end up having fast computers (that are orders of magnitude faster than anything 15 years ago) running bloated electron apps (that are sometimes even slower than their equivalent 15 years ago) and it's just frustrating.

[–] [email protected] 1 points 11 months ago

Just adding on that recursion could be problematic if used in the wrong way, like too many calls can over flow the call stack (assuming the compiler is not able to optimize that away).

[–] [email protected] 8 points 11 months ago (1 children)

Yeah but performance has way more to do with architecture than it does code readability. It doesn't matter how well you write your code, if it's an electron app it's going to use more ram than a native app. So I totally agree, but at the scale that it's a real problem it has more to do with architecture than the code in any given function.

[–] [email protected] 5 points 11 months ago (1 children)

Yeah but performance has way more to do with architecture than it does code readability.

Indeed, I am a bit notorious at work for speeding C++ code up by rewriting it in Python, and I have been able to do this not because my Python code is particularly fast but because the architecture of the C++ code was such a complicated and inefficient mess that it actually managed to be slower than Python.

[–] [email protected] 2 points 11 months ago

That just hurts me. I love to bag on Python for being slow. But that also totally makes sense.

[–] [email protected] 28 points 11 months ago (1 children)

Best for what?

For performance you almost always want an iterative instead of recursive. But performance is not the only constraint.

Some algorithms are innately recursive. Forcing them into an iterative paradigm usually makes them less readable.

If you are compelled to make a recursive algorithm iterative, consider using an explicit stack. Then you can keep the structure and side step the issues related to call overhead and stack depth.

[–] [email protected] 3 points 11 months ago

If you are compelled to make a recursive algorithm iterative, consider using an explicit stack.

yep, did that once to solve a specific problem, worked fine and if I recall correctly I could do it without making a total mess of my code

[–] [email protected] 18 points 11 months ago (2 children)

It depends on if the problem is recursive or iterative, and how much it needs to be optimized.

For example, you may use a for loop for a simple find and replace scheme for characters in a string, where you check each character one by one until you find one which matches the target, and then substitute that.

There are certainly recursive ways to do string replacement in strings which might be faster than an iterative search depending on implementation, but that's more optimization than I might need 99.9999% of the time

A recursive problem that's difficult to solve iteratively is browsing all the files in a folder and it's subfolders. Each folder may have several subfolders, which you then need to search, but then each of those folders can have subfolders. This problem can be solved fairly easily recursively but not as easily iteratively.

That's not to say it can't be solved that way, but the implementation may be easier to write

Recursive code, however, is more frequently prone to bugs which causes infinite recursion leading to crashes, as it is not a tool which is often used and requires several more fences to prevent issues. For example, in the folder example, if one were to encounter a shortcut to another folder and implement code to follow that shortcut as if it were a directory as well, then placing a shortcut to a folder within itself might cause the code to recurse infinitely without having a maximum recursion depth and or checking for previously seen folders.

[–] [email protected] 4 points 11 months ago

I generally find that writing code that requires a lot of “accounting” is very prone to mistakes that are easier to avoid with recursion. What I mean by this is stuff where you’re tracking multiple counters and sets on each iteration. It’s very easy to produce off by one errors in these types of algos.

Recursion, once you get the hang of it, can make certain kinds of problems “trivial,” and with tail-call recursion being implemented in many languages, the related memory costs have also been somewhat mitigated.

Loops are simpler for beginners to understand, but I don’t think recursion is all that hard to learn with a bit of practice, and can really clean up some otherwise very complicated code.

My general opinion is that we are all beginners for a short part of our journey, but our aim shouldn’t be to make everything simple enough that beginners never need to advance their skills. We spend most of our careers as journeymen, and that’s the level of understanding we should be aiming for/expecting for most code. Recursion in that context is absolutely ok from a “readability/complexity” perspective.

[–] [email protected] 4 points 11 months ago (5 children)

Could your folder tree problem also be solved with a whole loop instead? I'm very new but it seems like recursion is harder but possibly more optimized approach to loops or am I incorrect here?

[–] [email protected] 8 points 11 months ago

Any recursive algorithm can be made iterative and vise versa. It really depends on the algorithm if the function calls are a major factor in performance.

[–] [email protected] 4 points 11 months ago

Recursion is never more efficient than the best equivalent iterative solution. Recursion however allows you to solve some problems very easily and very neatly.

[–] [email protected] 4 points 11 months ago* (last edited 11 months ago)

I'm exaggerating a bit there. This problem is fairly easy to implement iteratively (e.g. keep a list of unbrowsed folders and keep adding to it), but that is not the case for all problems. Some will be easier to solve in one way, though fundamentally solvable either way

[–] [email protected] 2 points 11 months ago

A naive iterative implementation would be by adding and removing the folders/files from a list.

If tail call optimization works on the (recursive) example then that's (kinda) the compiler turning a recursive function into a loop.

[–] [email protected] 1 points 11 months ago

a whole entire loop? I'm partial to partial loops myself

[–] [email protected] 13 points 11 months ago (2 children)

When navigating a tree structure.

Processing files and folders, expression parsing, that kind of thing.

I've no idea why the factorial example is so popular, because it's one of the worst use cases for it. Still, I guess it can teach a new programmer what a stack overflow is.

[–] [email protected] 4 points 11 months ago

I’ve no idea why the factorial example is so popular,

It is because anyone who has done anything with math (as is the case with cs students), will know how the factorial is defined in math which is also a recursive definition, so the code ends up looking almost exactly like the definition in math, and because of its simplicity, it's excellent to introduce students to the idea of recursion. So, it's a combination of familiarity and simplicity that makes it such a well known example.

Of course, in the real world you would use the implementation from a library. So whether recursion or iteration is better for factorials isn't that important of a question, since you won't be using your solution in a normal situation. The factorial example is supposed to be only used as nothing more than an example.

[–] [email protected] 1 points 11 months ago

Came here to say this.

[–] [email protected] 10 points 11 months ago (2 children)

Generally, some algorithms are more easily expressed as recursive functions than iterative loops. ...and vice versa. And realistically, that's how you should choose ninety nine percent of the time.

But if you want to get into the weeds... Prefer iteration unless you know one or more of the following:

  • Your maximum iteration depth is bounded and cannot overflow your machine's stack depth.
  • Your algorithm can be implemented with tail-call recursion AND your language supports the same.
  • Your senior/team lead wants a recursive solution.

Because in environments where none of the above are true, iterative solutions are usually more performant, safer, and better understood.

[–] [email protected] 2 points 11 months ago* (last edited 11 months ago)

Your algorithm can be implemented with tail-call recursion AND your language supports the same.

Just to nitpick but the compiler/interpreter needs to support tail-call recursion, not just the language. For example, tail-call recursion is part of the language spec for JavaScript (ECMAScript 6), but only certain engines actually support it (https://compat-table.github.io/compat-table/es6/ Ctrl+F tail call).

[–] arthur 2 points 11 months ago* (last edited 11 months ago)

Perfect answer.

[–] [email protected] 8 points 11 months ago (1 children)

IMHO almost never. Except for tree traversal, maybe.

[–] [email protected] 2 points 11 months ago

I would agree. Only if the performance is extremely similar but the readability (for some reason) is significantly better for the recursive solution would I choose that.

[–] [email protected] 7 points 11 months ago* (last edited 11 months ago)

The only time I've ever really needed recursion is when I'm doing something that needs to map out some sort of tree or heavily nested object.

One example that comes to mind is when I needed a function that acts like querySelector, but also searches through shadowroots. Since querySelector does not natively search within shadowroots, I had to write a recursive function that basically starts at the root and recursively searches each node for a shadowdom, goes inside, and runs itself again.

It's definitely not the most performant solution, but it is sometimes necessary.

[–] [email protected] 6 points 11 months ago* (last edited 11 months ago)

When doing functional programming, you can't really do loops (because of referential transparency, you can't update iterators or indices). However, recursion still works.

[–] [email protected] 6 points 11 months ago

It depends on the programming language. Some languages prefer one style, others another.

[–] [email protected] 6 points 11 months ago (1 children)

In Elixir & Erlang, they don’t even have a for-loop construct. You have to use recursion. And I think that’s beautiful. I also think tail-call optimization is beautiful.

[–] [email protected] 5 points 11 months ago* (last edited 11 months ago) (1 children)

Elixir does have for loops.

https://hashrocket.com/blog/posts/elixir-for-loops-go-beyond-comprehension

That being said, I have worked at a company who uses Elixir 4 years now and I have never once written one.

[–] [email protected] 3 points 11 months ago

Oh you’re so right, I never use those so I completely forgot :X

[–] [email protected] 5 points 11 months ago

After reading all the given responses, I'll go with the one not listed.

"When the interviewer asks you to."

[–] [email protected] 4 points 11 months ago

Do you have a concrete example to ask about? Are you thinking of a particular language?

Basically, do whatever is most idiomatic in your language. It also depends on what the control flow really looks like. General recursion translates to a while loop where you put stuff on a stack, and the recursive form may make more sense. Tail recursion translates to a jump or a for loop, and the loop is often more idiomatic.

[–] [email protected] 4 points 11 months ago* (last edited 11 months ago)

I haven't contemplated this question before so my answer may be incomplete or incorrect, and I've also had like two double scotches, but I feel like the answer is when something is iterative, you can have a job half done and know when it is. For example adding a field to every object in a list has a definite midpoint whether you calculate it or not.

Recursion is for things that are either 100% done or not done at all. In other words until you determine all the elements, you can't and haven't done anything. For example, parsing that includes matched brackets. You can't possibly know anything until you've found the last bracket.

[–] [email protected] 4 points 11 months ago (1 children)

I pretty much always use list/iterator combinators (map, filter, flat_map, reduce), or recursion. I guess the choice is whether it is convenient to model the problem as an iterator. I think both options are safer than for loops because you avoid mutable variables.

In nearly every case the performance difference between the strategies doesn't matter. If it does matter you can always change it once you've identified your bottlenecks through profiling. But if your language implements optimizations like tail call elimination to avoid stack build-up, or stream fusion / lazy iterators then you might not see performance benefits from a for loop anyway.

load more comments (1 replies)
[–] [email protected] 3 points 11 months ago

If you switch to Scheme (or the few other tail-recursive languages), you can always use recursion, and it's the most efficient solution. It's a bit of a weird shift at first, and the hand-holding do, dotimes, loop macros will let you transition at your own pace, but soon all your "loops" will just be named-let recursion.

[–] [email protected] 3 points 11 months ago* (last edited 11 months ago) (1 children)

depends on the language and the compiler, pretty sure gcc without at least -O2 doesnt do tail call elimination(and still itll be slower than iteration), and rust didnt have it/low priority and when i was introducing myself to js it didnt have tco everywhere either. so just write in a way that is idiomatic to your language. in haskell recursion is encouraged, in part because it is guaranteed that it will be optimized by the compiler.

regardless of the language if your recursive function is poorly designed, its going to result in stack overflow with sufficiently large inputs

[–] [email protected] 3 points 11 months ago

oh this made me remember that wasm got tco, which is exciting

[–] [email protected] 2 points 11 months ago* (last edited 11 months ago)

I've found that it's usually best to keep it iterative if it can be done with a simple data structure, like stack (DFS) or queue (BFS). But that's not always a simple task.

One common case where recursion is actually more natural is post-order tree traversals. For example if you had a tree where every node held a number and you wanted to calculate the sum of each node's descendants. This is natural with recursion because a node is able to directly sum the values returned from recursive calls. Doing this with an explicit stack would be awkward, because you don't usually get to visit a node twice (once to put children on the stack, once again to accumulate the descendants sum).

Like, just look how weird this algorithm is: https://www.geeksforgeeks.org/iterative-postorder-traversal-using-stack/ I don't think I've ever done it this way.

[–] [email protected] 2 points 11 months ago

Depends on the environment you're working in. If you're doing a lot of collaboration, it might be that you want to choose whichever of the two is more legible (almost always the loop, but perhaps the recursion). If you are in an environment where the most efficient approach is prioritised over readability, perhaps recursion would have a strong case in some circumstances.

But I think, generally, you need to answer the underlying question, not "recursion or loop". Can I improve code readability? Is this problem well suited to recursion? Am I just using recursion because it's elegant? The correct approach will reveal itsself!

[–] [email protected] 1 points 11 months ago

As a rule of thumb, I would say that recursion should never be used in place of a for loop.

If you don't know what you're doing with a recursive function then you risk pushing stuff to your call stack proportionally to the number of items you want to iterate over.

If your collection and/or the size of the stuff you're pushing to the stack is large enough, your app will crash.

If you know enough to avoid growing the call stack then you know enough to not rely on third parties to figure out if you need an iteration of recursion.

[–] [email protected] 1 points 11 months ago (1 children)

Whenever possible, you should build up a cache dynamically (approaching the desired answer step by step) instead of using recursion, which typically has no answer until it reaches the terminal state and thereby has to propagate all the way down and then propagate back up

[–] [email protected] 3 points 11 months ago

This is only particularly relevant for recursive algorithms with multiple dependencies (I.e. our old favorite the fibonocci sequence).

That is unless you're talking about really big problems where you'd want to persist the state to disk as you go so you can resume computation if you, for instance, suffer a power outage while computing step 3,198,217 out of 3,198,218.

[–] [email protected] 1 points 11 months ago

Whenever it better expresses what you mean. In most cases it doesn't make a huge difference because the compiler don't care

load more comments
view more: next ›