Wait areBooleanEqual returns false when they are equal?
this post was submitted on 28 Oct 2024
504 points (98.5% liked)
Programming Humor
2644 readers
11 users here now
Related Communities [email protected] [email protected] [email protected] [email protected]
Other Programming Communities [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
founded 1 year ago
MODERATORS
That's not even the worst part. What the fuck does a function named Compare_anything do? Does it return anything? It sounds like nothing but a side effect.
Usually comparison functions are supposed to return an integer and are usually useful for sorting. However this one returns a bool so it's both useless and terribly named.
The unnecessary and confusing functions are horrible, yes, but I'd still say that the fact that they're wrong is the "worst" part.
load more comments
(1 replies)
Don’t forget the invocation
if (CompareBooleans(a, b) == true)
elseif(CompareBooleans(b,a) != false)
Management: Gee whiz, we really have no idea how to gauge productivity to decide who gets promoted. We could manage. Or, better, we could just have someone write a script that pulls info from git on how many lines of code each person has written.
Programmers:
I promote based on lines of code removed.
I quit based on idiotic metrics
Which is all the easier to do when you start off with a higher number...
load more comments
(1 replies)
load more comments
(1 replies)
There’s no way, that’s so insane it has layers.
At first, I thought the shitty methods were the joke 😱😱😱
This is code after working 16 hours
I'd give my right hand this is a code review problem. Someone extracted a method returning true false. Then an intern came along and was told to refactor. They saw a lot of comparisons and "extracted" them.
My coworker made an array of book to express a status. This is no doing of an intern but a much eviler force at play.
load more comments
(1 replies)
"You aren't writing enough lines of code!" - Management
My boss's boss, a former Ops manager who liked to keep track of system stats, once asked her why the CPU usage on the dev box had decreased that month. Weren't the devs doing any work?
Two wrongs don’t make a right, but sometimes in programming, two bugs can cancel each other out.
Whoever wrote this is more than capable of using it incorrectly.
Is this part of Elons "How many lines of choice have you written?" interview?
Those are rookie lines of code numbers right there.
I would have done it without the ==
internal static bool AreBooleansEqual(bool orig, bool val)
{
if(orig)
{
if(val)
return false
return true
}
if(val)
return true
return false
}
Don't know why their code returns false when they are equal but I'm not going to dig through old code to refactor to use true instead of false.
Put more curly brackets around your if (val) true statement for 4 more lines, put elses in there for more lines even.
I should have created a local variable to store the result variable and return after the if statements. I just couldn't help to make it look partially nice. My brain just doesn't think at this high caliber of LOC optimizations.
New optimized LOC version:
internal static bool AreBooleansEqual(bool orig, bool val)
{
bool result;
if(orig)
{
if(val)
{
result = false;
}
else
{
result = true;
}
}
else
{
if(val)
{
result = true;
}
else
{
result = false;
}
}
return result;
}
My previous LOC: 12
New LOC version: 27
load more comments
(3 replies)
You can tell they're amateurs. It's not obfuscated enough. They won't be able to keep their job.
They clearly need an abstract boolean comparison factory.
var CompareBooleans = new ComparatorFactory().BooleanComparator(new BooleanComparisonByEqualityPolicy());
if (CompareBooleans(a, b) == true) {
System.Out.PrintLn("Sames!!!");
}
...
But now that I've written this, it's C#, so it's missing dependency injection.
I can imagine Uncle Bob be proud of this Clean Code (TM)
My guess to why there’s two functions is because it was originally only internal, and the programmer realized they needed public as well, but changing internal to public is too scary so they created a new method instead.
load more comments
(1 replies)
"We need to obfuscate our code to prevent reverse engineering"
The obfuscation in question:
load more comments
(2 replies)
If this were a Node module, I wouldn't even be surprised.
Clearly it should be return orig == val
Duh
I'm a bit disappointed there isn't a call to GetBooleanValue in there
!NOT
Who's there?
!!Naughty Knots
But how do you test for FILE_NOT_FOUND?
Where are the unit tests?
Straight from the famous book "Making LOCs for Dummies"
I misread it as CompareBolians. No more Star Trek memes for me today.
load more comments
(1 replies)
view more: next ›